Add Search to Collaborator List #1764
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…borators in collaborators view model
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This pull request follows the changes from the
theck13:heck/remove-collaborator-toastbranch. Merge the pull request associated with that branch, #1760, first to avoid merge conflicts and to isolate the changes in this pull request (theck13:heck/remove-collaborator-toast...theck13:heck/add-collaborator-search) for easier review.Fix
Add search to Collaborator list. The code and tests were written to closely match the search feature on the Edit Tags screen. See the screenshots and video below for illustration.
Warning
The screenshot composites are large images, 2280 pixels × 9996 pixels, and may take a while to load.
Screenshots
Video
1752_add_collaborator_search.mp4
Relates: #1752
Test
Follow the steps below in both dark and light modes.
Run the tests below and verify all pass.
AddCollaboratorViewModelTestCollaboratorsViewModelTestSimperiumCollaboratorsRepositoryTestReview
Only one developer is required to review these changes, but anyone can perform the review.
Release
These changes do not require release notes.